Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make interpreter and TyAndLayout type Debug impl independent of Ty debug impl #115866

Merged
merged 2 commits into from
Sep 16, 2023

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Sep 15, 2023

This fixes some (but not all) of the fallout from #115661.

Second commit is taken from #107084 (and slightly adjusted); I preserved the original git author information.

@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2023

r? @TaKO8Ki

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 15, 2023
@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2023

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

1 similar comment
@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2023

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@RalfJung RalfJung changed the title make interpreter type Debug impl independent of Ty debug impl make interpreter and tyAndLayout type Debug impl independent of Ty debug impl Sep 15, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 15, 2023

📌 Commit 591e11b has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2023
@RalfJung RalfJung changed the title make interpreter and tyAndLayout type Debug impl independent of Ty debug impl make interpreter and TyAndLayout type Debug impl independent of Ty debug impl Sep 15, 2023
@RalfJung
Copy link
Member Author

I forgot to also remove the normalization clause that is not needed any more.
@bors r=compiler-errors

@bors
Copy link
Contributor

bors commented Sep 15, 2023

📌 Commit 71cab64 has been approved by compiler-errors

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2023
…iaskrgr

Rollup of 2 pull requests

Successful merges:

 - rust-lang#115607 (clarify that unsafe code must not rely on our safe traits)
 - rust-lang#115866 (make interpreter and TyAndLayout type Debug impl independent of Ty debug impl)

Failed merges:

 - rust-lang#115873 (Make `TyKind::Adt`'s `Debug` impl be more pretty)
 - rust-lang#115884 (make ty::Const debug printing less verbose)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 53cd978 into rust-lang:master Sep 16, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2023
Rollup merge of rust-lang#115866 - RalfJung:interpret-debug, r=compiler-errors

make interpreter and TyAndLayout type Debug impl independent of Ty debug impl

This fixes some (but not all) of the fallout from rust-lang#115661.

Second commit is taken from rust-lang#107084 (and slightly adjusted); I preserved the original git author information.
@rustbot rustbot added this to the 1.74.0 milestone Sep 16, 2023
@RalfJung RalfJung deleted the interpret-debug branch September 16, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants